[PATCH] net/wanrouter/wanproc.c

[Akash Jain]

Hi All,
I am working with Dawson Engler's meta-compillation group @ Stanford.

In net/wanrouter/wanproc.c the authors check for a bad copy_to_user and
immediately return -EFAULT.  However, it is necessary to rollback some
allocated memory.  This can leak memory over time, thus leading to
system instability and lack of resources.

Thanks!
-Akash Jain

--- net/wanrouter/wanproc.c.orig	Thu Apr 12 12:11:39 2001
+++ net/wanrouter/wanproc.c	Thu May 17 12:52:05 2001
@@ -267,8 +267,10 @@
 		offs = file->f_pos;
 		if (offs < pos) {
 			len = min(pos - offs, count);
-			if(copy_to_user(buf, (page + offs), len))
-				return -EFAULT;
+			if(copy_to_user(buf, (page + offs), len)){
+			        kfree(page);
+			        return -EFAULT;
+			}
 			file->f_pos += len;
 		}
 		else