Re: [PATCH] drivers/net/others

Lars Marowsky-Bree (lmb@suse.de)
Thu, 24 May 2001 10:51:37 +0200


On 2001-05-24T10:45:25,
Tobias Ringstrom <tori@unhappy.mine.nu> said:

> > if (!printed_version++)
> > - printk(version);
> > + printk("%s", version);
> >
> > DMFE_DBUG(0, "dmfe_init_one()", 0);
> >
>
> Could you please explain the purpose of this change? To me it looks less
> efficient in both performance and memory usage.

Potentially, version might include stuff which is interpreted by printk if not
quoted - the above fixes this. Paranoia always helps ;-)

Sincerely,
Lars Marowsky-Brée <lmb@suse.de>

-- 
Perfection is our goal, excellence will be tolerated. -- J. Yahl

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/