Re: ac15 and 2.4.5-pre6, pwc format conversion

Erik Mouw (J.A.K.Mouw@ITS.TUDelft.NL)
Fri, 25 May 2001 13:15:02 +0200


On Fri, May 25, 2001 at 10:48:12AM +0200, Nemosoft Unv. wrote:
> On 25-May-01 Norbert Preining wrote:
> > According to ac ChangeLog:
> > o Rip format conversion out of the pwc driver (me)
> > | It belongs in user space..
> >
> > This change is included in 2.4.5-pre6, but
> > drivers/usb/pwc-uncompress.c
> > pwc-uncompress.c:185: warning: implicit declaration of function
> > `vcvt_420i_420p'
>
> Thatīs what you get for ripping out the guts of a driver. Have a nice day.

The format conversion shouldn't be there in the first place. Format
conversion is policy, so it doesn't belong in kernel. Note for example
that none of the sound drivers does sample rate conversion although
some sound chips are locked at 48kHz only.

Erik

-- 
J.A.K. (Erik) Mouw, Information and Communication Theory Group, Department
of Electrical Engineering, Faculty of Information Technology and Systems,
Delft University of Technology, PO BOX 5031,  2600 GA Delft, The Netherlands
Phone: +31-15-2783635  Fax: +31-15-2781843  Email: J.A.K.Mouw@its.tudelft.nl
WWW: http://www-ict.its.tudelft.nl/~erik/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/