Re: WOL with 3c59x and 2.4.6-pre6 breaks WOL
Jeff Garzik (jgarzik@mandrakesoft.com)
Mon, 02 Jul 2001 12:02:59 -0400
Andrew Morton wrote:
> --- linux-2.4.6-pre8/drivers/pci/pci.c Sun Jul 1 16:11:25 2001
> +++ linux-akpm/drivers/pci/pci.c Tue Jul 3 01:28:35 2001
> @@ -425,7 +425,7 @@ int pci_enable_wake(struct pci_dev *dev,
>
> if (enable) value |= PCI_PM_CTRL_PME_STATUS;
> else value &= ~PCI_PM_CTRL_PME_STATUS;
> -
> + value |= PCI_PM_CTRL_PME_ENABLE;
> pci_write_config_word(dev, pm + PCI_PM_CTRL, value);
>
> return 0;
wrong but it seems you spotted a bug in the code -- set/clear _ENABLE
right above your change here. maybe read and write _STATUS
unconditionally, for paranoia.
--
Jeff Garzik | The LSB is a bunch of crap.
Building 1024 | E-mail for details.
MandrakeSoft |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/