Re: [PATCH] starfire net driver update

[Ion Badulescu]

On 11 Jul 2001, Juri Haberland wrote:

> > Also, if you feel adventurous, search for these lines in the driver:
> >         /* Configure the PCI bus bursts and FIFO thresholds. */
> >         np->tx_mode = 0x0C04;           /* modified when link is up. */
> > *       writel(0x8000 | np->tx_mode, ioaddr + TxMode);
> > *       writel(np->tx_mode, ioaddr + TxMode);
> > 
> > and comment out those two marked with a *. At that point you should have 
> > essentially the 2.4.6 driver, so see if they behaves similarly.
> 
> I'll try that tomorrow.

Actually, try this patch first. I believe it will fix your problems, but
I'd like to confirm it.

Thanks,
Ion

-- 
  It is better to keep your mouth shut and be thought a fool,
            than to open it and remove all doubt.
------------------------------
--- /src/vanilla/linux-2.4/drivers/net/starfire.c	Thu Jul 12 02:47:25 2001
+++ linux/drivers/net/starfire.c	Thu Jul 12 01:35:04 2001
@@ -987,12 +987,12 @@
 	struct netdev_private *np = dev->priv;
 	u16 reg0;
 
+	mdio_write(dev, np->phys[0], MII_ADVERTISE, np->advertising);
 	mdio_write(dev, np->phys[0], MII_BMCR, BMCR_RESET);
 	udelay(500);
 	while (mdio_read(dev, np->phys[0], MII_BMCR) & BMCR_RESET);
 
 	reg0 = mdio_read(dev, np->phys[0], MII_BMCR);
-	mdio_write(dev, np->phys[0], MII_ADVERTISE, np->advertising);
 
 	if (np->autoneg) {
 		reg0 |= BMCR_ANENABLE | BMCR_ANRESTART;