Re: ioctl bug?

[Andreas Dilger]

Gary writes:
> I think I have found a bug in the kernel.
> 
> starting with 2.4.5ac23 and continuing through both 2.4.6 and
> 2.v.6-ac2 Whenever I try to do a lsattr or chattr on a directory
> I get:
> 
> 	"Inappropriate ioctl for device While reading flags"

Yet another case of Linux pro-active bug-fixing.  I have already sent
a patch for this to Linus and Alan.  It seems I CC'd ext2-devel, but
not linux-kernel.

Here is the patch again.  It was likely caused by Al Viro's major
overhaul of the ext2 directory code, to move it into the page cache.

Cheers, Andreas
===========================================================================
--- linux-2.4.6.orig/fs/ext2/dir.c	Thu Jun 28 14:28:24 2001
+++ linux-2.4.6-aed/fs/ext2/dir.c	Tue Jul 10 22:59:12 2001
@@ -576,5 +576,6 @@
 struct file_operations ext2_dir_operations = {
 	read:		generic_read_dir,
 	readdir:	ext2_readdir,
+	ioctl:		ext2_ioctl,
 	fsync:		ext2_sync_file,
 };
-- 
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert