Re: [PATCH/CFT] Fix NFS mmap problems w.r.t. page_launder() in

[Anton Altaparmakov]

At 11:48 14/07/2001, Trond Myklebust wrote:
[snip]
>+/*
>+ * For the moment, the only task for the NFS clear_inode method is to
>+ * release the mmap credential
>+ */
>+static void
>+nfs_clear_inode(struct inode *inode)
>+{
>+       struct rpc_cred *cred = NFS_I(inode)->mm_cred;
>+
>+       if (cred) {
>+               put_rpccred(cred);
>+               NFS_I(inode)->mm_cred = 0;
>+       }
>+}

I know it's nit-picking but wouldn't it be cleaner/faster to do:

+static void
+nfs_clear_inode(struct inode *inode)
+{
+       struct rpc_cred **cred = &NFS_I(inode)->mm_cred;
+
+       if (*cred) {
+               put_rpccred(*cred);
+               *cred = 0;
+       }
+}

Just a thought before waking up properly... Haven't looked at the generated 
assembly or anything.

Best regards,

Anton