Re: (patch-2.4.6) Fix oops with Iomega Clik! (ide-floppy)
Jeff Garzik (jgarzik@mandrakesoft.com)
Sat, 14 Jul 2001 14:21:38 -0400
David Woodhouse wrote:
>
> cw@f00f.org said:
> > If it changes vmlinux by a single byte, I might agree.... all it does
> > is close off and older depricated API.
>
> Why is the sane API deprecated in favour of the implementation-specific one?
>
> If we must standardise on a single header file to include, surely we should
> do it the other way round?
>
> Index: include/linux/slab.h
> ===================================================================
> RCS file: /inst/cvs/linux/include/linux/slab.h,v
> retrieving revision 1.1.1.1.2.12
> diff -u -r1.1.1.1.2.12 slab.h
> --- include/linux/slab.h 2001/06/08 22:41:51 1.1.1.1.2.12
> +++ include/linux/slab.h 2001/07/14 18:08:37
> @@ -4,6 +4,10 @@
> * (markhe@nextd.demon.co.uk)
> */
>
> +#ifndef _LINUX_MALLOC_H
> +#warning Please do not include linux/slab.h directly, use linux/malloc.h instead.
> +#endif
malloc.h is extra indirection we don't need. IMHO
/* malloc.h */
#include <linux/slab.h>
is a windows interface. Linux wrappers should be kept to a minimum...
--
Jeff Garzik | A recent study has shown that too much soup
Building 1024 | can cause malaise in laboratory mice.
MandrakeSoft |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/