Re: unitialized variable in 2.4.7 (sym53c8xx, dmi_scan)

richard offer (offer@sgi.com)
Wed, 25 Jul 2001 14:58:28 -0700


* frm alan@lxorguk.ukuu.org.uk "07/25/01 22:25:32 +0100" | sed '1,$s/^/* /'
*
*> static __init int disable_ide_dma(struct dmi_blacklist *d)
*> {
*> # ifdef CONFIG_BLK_DEV_IDE
*> @@ -169,6 +170,7 @@
*> # endif
*> return 0;
*> }
*> +#endif
*
* This just makes it harder to finish the merges

Huh ? Was it a bad patch ?

*
*> makes that automatic.
*> ===== drivers/scsi/sym53c8xx.c 1.6 vs edited =====
*> --- 1.6/drivers/scsi/sym53c8xx.c Thu Jul 5 04:28:16 2001
*> +++ edited/drivers/scsi/sym53c8xx.c Wed Jul 25 13:37:10 2001
*> @@ -6991,7 +6991,7 @@
*>
*> static void ncr_soft_reset(ncb_p np)
*> {
*> - u_char istat;
*> + u_char istat=0;
*> int i;
*>
*> if (!(np->features & FE_ISTAT1) || !(INB (nc_istat1) & SRUN))
*
* And this means when we get a real bug with istat not being assigned it
* wont be seen.
*

Isn't the only way that istat could be unassigned would be for the for loop
never to be executed. An unlikely event, but the compiler sees it as a
warning and means its not possible to build the code with -Werror.

richard.

-----------------------------------------------------------------------
Richard Offer Technical Lead, Trust Technology, SGI
"Specialization is for insects"
_______________________________________________________________________

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/