Re: Announce: Kernel Build for 2.5, Release 1.1 is available.

[Tom Rini]

On Sun, Aug 12, 2001 at 11:21:22AM +1000, Keith Owens wrote:
> On Sat, 11 Aug 2001 15:02:55 -0700, 
> Tom Rini <[e-mail]> wrote:
> >On Sun, Aug 12, 2001 at 01:03:00AM +1000, Keith Owens wrote:
> >
> >> Changes from Release 1.
> >[snip]
> >>   Document kbuild targets and C to assembler conversions.  As always,
> >>   Documentation/kbuild/kbuild-2.5.txt is your friend.
> >
> >Okay, I've played with this a bit on PPC, and got it working to boot :)
> >Now here's what I see as the slight problems with it.  At least on PPC
> >what we do is generate the offset bits, and then have another file,
> >arch/ppc/kernel/ppc_asm.h include that file and have some other useful
> >macros for .S files.  So any of the .S files which include ppc_asm.h
> >would need an additional
> >extra_aflags(foo.o $(src_includelist /arch/$(ARCH)))
> 
> That will be required for all asm code that includes offsets.h, on all
> architectures, I doubt there will be more than 10 on any arch.

Hopefully not much more than 10, I hope.

> The alternative of having code in some arch directory updating
> include/asm-$(ARCH)/offsets.h is worse.  It is a terrible design to
> have code in one makefile updating files in another directory.  It is a
> layer violation which is always a bad idea.

Right.  I figured it'd be worth pointing out, if nothing else.

-- 
Tom Rini (TR1265)
http://gate.crashing.org/~trini/