Re: [BUG][PATCH] in sys_swapoff() path

Jeremy Linton (jlinton@interactivesi.com)
Mon, 13 Aug 2001 17:18:28 -0500


From: "Linus Torvalds" <torvalds@transmeta.com>

> Can you test that the appended version does the same thing for you? I made
> the mm/memory.c check a bit stricter (it should be the _same_ pte entry,
...
> Plus this has Rik's swapspace full patch - fixed to NOT unconditionally
....
> Jeremy, Rik, please verify my changes..

Looks good!!! I grabbed 2.4.8 and put it on my machine, closely inspected
your changes to my original patch and quickly took a look at Rik's code.
They both look fine and my tests seem to prove that they are. On the other
hand, the swapoff times are slower than 2.4.7pre6 with my patches applied, I
assume that is probably something else in the kernel. This kernel version
also has some problems running the stress program that helped to find those
bugs originally. Now when it is running, xosview 'bails' out with a "Can not
open file: /proc/interrupts" or similar message after a couple minutes of
steady thrashing.

If I get a chance, I will look at the xosview problems as well as some of
the other strange behaviors.

jlinton

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/