Re: [PATCH] nvram driver work

Dave Jones (davej@suse.de)
Tue, 14 Aug 2001 13:26:56 +0200 (CEST)


On Mon, 13 Aug 2001, Tim Hockin wrote:

Hi Tim,

> This patch does 4 main things:
> 1) Add generic support for paged nvrams, and supporting ioctls
> 2) Add a 'Magic' page for system-specific NVRAM-like things
> 3) Add support for NatSemi PC[89]7317 paged nvram
> 4) Add support for Cobalt's magic page

No problem with that stuff.

> It also does some re-formatting of things that looked awful with tabstops >
> 2.

With the tabstops set to the value defined at the bottom of the file (4)
it looks fine. Your changes break the indentation of the rest of the
file when viewed as it was originally created.

> We've been using this patch for months. Please apply it to the next 2.4.x
> kernel, or let me know if you have problems with it. It is against 2.4.8
> and should patch cleanly (just a bit of fuzz).

line 116 needs changing also, to by 128-RTC_FIRST_BYTE

regards,

Dave.

-- 
| Dave Jones.        http://www.suse.de/~davej
| SuSE Labs

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/