Re: RFC: poll change

Herbert Xu (herbert@gondor.apana.org.au)
Wed, 15 Aug 2001 08:38:02 +1000


David S. Miller <davem@redhat.com> wrote:
> From: Tim Hockin <thockin@sun.com>
> Date: Tue, 14 Aug 2001 14:08:40 -0700

> poll() currently does not allow you to pass more fd's than you have open.

> Tim, please check the latest sources, this has been fixed
> in 2.4.x for several months.

Hmm, it still seems to be wrong:

/* Do a sanity check on nfds ... */
if (nfds > NR_OPEN)
return -EINVAL;

if (nfds > current->files->max_fds)
nfds = current->files->max_fds;

The second if statement should be removed. And it might be better to use
current->rlim[RLIMIT_NOFILE].rlim_cur instead of NR_OPEN.

-- 
Debian GNU/Linux 2.2 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/