RE: RFC: poll change

David Schwartz (davids@webmaster.com)
Wed, 15 Aug 2001 03:40:50 -0700


> From: Herbert Xu <herbert@gondor.apana.org.au>
> Date: Wed, 15 Aug 2001 08:38:02 +1000
>
> Hmm, it still seems to be wrong:
> ...
>
> if (nfds > current->files->max_fds)
> nfds = current->files->max_fds;
>
> The second if statement should be removed. And it might be
> better to use
> current->rlim[RLIMIT_NOFILE].rlim_cur instead of NR_OPEN.
>
> It has to be limited to "max_fds", that is how many files we may
> legally address in current->files!

Though stupid, I believe it is perfectly legal to, say, have one socket
open and poll for it with two separate entries, one checking readability and
one checking writability.

DS

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/