Re: md/multipath: Multipath, Multiport support and prototype patch for round robin routing

Christoph Hellwig (hch@ns.caldera.de)
Wed, 15 Aug 2001 22:34:53 +0200


In article <20010723133242.B970@dyn9-47-16-69.des.beaverton.ibm.com> you wrote:
> I've been looking at the multipath support Ingo Molnar added to md as
> included in RedHat 7.1. I'm looking at various improvements that might
> be possible. To try to get some discussion going, I posting some ideas
> of things I thgink could be improved, and some patches for a prototype
> to add round robin routing.
>
> Some of the things that I think could be done that would improve md, in
> no particular order: different routing options ( prefered route, round
> robin, static weighted, dynamic weighted ), improved error handeling,
> automatic route recovery, automatic device discovery, automatic device
> identification. Some of these may not be feasible and others may have
> some other features.
>
> All comments welcome

First it would be so much easier to compare this to the current code
if one would not have to download megabytes of redhat kernel-rpms
(ok we have it on kn.org now), extract the four or five patches and
adopt them to a slightly different tree, but could find it in the stock
or at least -ac tree. Ingo, is there any specici reason why you didn't
send it to Alan yet? I stoped my development of the same feature because
I saw yours was moe coplete and now it doesn't get merged..

The second comment actually goes to you, Brian: could you please try to
create unified diffs (diff -u)? It's sooo much easier to read..

> +
> + static struct multipath_dev_table multipath_dev_template = {
> + "",
> + {
> + {MULTIPATH_ROUTING, "routing", NULL, sizeof(int), 0644,
> + NULL, &proc_dointvec},

Shouldn't this be a property of the md device, instead of a sysctl?
I planned to write that information in the md superblock for my design.

Christoph

-- 
Of course it doesn't work. We've performed a software upgrade.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/