Re: How should nano_sleep be fixed (was: ptrace(), fork(), sleep(),

george anzinger (george@mvista.com)
Thu, 16 Aug 2001 07:16:27 -0700


Russell King wrote:
>
> On Thu, Aug 16, 2001 at 12:17:46PM +0200, christophe barbé wrote:
> > > asmlinkage long sys_nanosleep(struct timespec *rqtp, struct timespec
> > > *rmtp)
> > > {
> > > struct timespec t;
> > > unsigned long expire;
> > > + struct pt_regs * regs = (struct pt_regs *) &rqtp;
>
> Note also that this is bogus as an architecture invariant.
>
> On ARM, we have to pass a pt_regs pointer into any function that requires
> it.
>
Does that mean that any function that requires pt_regs _must_ not be in
common code? Isn't there a better solution than implementing these
functions over and over for each platform?

George
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/