Re: 2.4.9 does not compile [PATCH]

Alan Cox (alan@lxorguk.ukuu.org.uk)
Fri, 17 Aug 2001 00:14:05 +0100 (BST)


> > The args and semantics of min/max changed to take
> > a type first argument,
>
> They did? This three argument min is butt-ugly, not to mention a completely
> original way of expressing the idea that is very much in conflict with every
> other expression of min I have ever seen.
>
> What is wrong with using typeof? If you must have a three argument min,
> could it please be called "type_min" of similar.

It also doesnt solve all the cases. Basically its just ensuring everyone
doing portable code has to go and change all their macros to MIN and MAX
instead. Or use if statements, which with all the subtle suprises of
type casting is actually often a far far better idea and probably should
be encouraged a lot more in the kernel

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/