Re: [patch] dz.c 64 bit locking issues

Maciej W. Rozycki (macro@ds2.pg.gda.pl)
Fri, 17 Aug 2001 17:57:03 +0200 (MET DST)


On Fri, 17 Aug 2001, Ralf Baechle wrote:

> > The dz.c driver has an instance where it does save_flags() to a 32 bit
> > type which isn't safe for 64 bit boxen.
>
> It's safe because a MIPS only driver.

Not necessarily. It might be safe now, but there is a TURBOchannel
serial card with DZ11-compatible chipset that could be driven by the dz.c
code after a few tweaks. And chances are someone will finish writing
support for TURBOchannel Alphas one day...

The change is harmless anyway.

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/