Re: [IDEA+RFC] Possible solution for min()/max() war

[Henning P. Schmiedehausen]

Linus Torvalds <[e-mail]> writes:

>I'll show you a real example from drivers/acorn/scsi/acornscsi.c:

>	min(host->scsi.SCp.this_residual, DMAC_BUFFER_SIZE / 2);

>this_residual is "int", and "DMAC_BUFFER_SIZE" is just a #define for
>an integer constant. So the above is actually a signed comparison, and
>I'll bet you that was not what the author intended.

And the mistake of the author was not to write "unsigned int this_residual".
That's the bug. Not the min() function.

	Regards
		Henning

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen       -- Geschaeftsfuehrer
INTERMETA - Gesellschaft fuer Mehrwertdienste mbH     [e-mail]

Am Schwabachgrund 22  Fon.: 09131 / 50654-0   [e-mail]
D-91054 Buckenhof     Fax.: 09131 / 50654-20