Re: [PATCH] blkgetsize64 ioctl

Michael E Brown (michael_e_brown@dell.com)
Thu, 30 Aug 2001 12:02:13 -0500 (CDT)

And your response to the rest of the points I raised would be?

I'm sorry about e2fsprogs. If I had known a bit better (this was my first
kernel patch), I would have added a magic number to the struct you pass
in, and that would have prevented this little bit of braindamage.

--
Michael


On Thu, 30 Aug 2001, Ben LaHaise wrote:


> On Thu, 30 Aug 2001, Michael E Brown wrote:
>
> > And your last point about risking unexpected disk-io due to an incorrect
> > IOCTL, I would say that is a pretty unlikely in practice. First, I do
> > parameter checking on what was passed to the IOCTL, and if things don't
> > match, no io is done. Second, how likely is it that you a) call ioctl with
> > a (disk) block device, b) pass the wrong ioctl, c) pass along enough data
> > to pass the checks in the ioctl, and d) pass along a valid pointer to 512
> > bytes of data to overwrite something?
>
> e2fsprogs-1.23 on x86 does this.
>
> 		-ben
>
>



-- 
Michael Brown
Linux OS Development
Dell Computer Corp


  If each of us have one object, and we exchange them,
     then each of us still has one object.
  If each of us have one idea,   and we exchange them,
     then each of us now has two ideas.




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/