> hi,
>
> this is rather cosmetical than functional, but in arp.c,
> in arp_send(), on line 489
>
> skb->dev=dev;
>
> is assigned. in line 563, still in the same routine, it is
> assigned again without skb or skb->dev being changed. so I guess
> this second assignment is not neccessary. I can't see where
> skb->dev is changed within the 80 lines. so, we could remove
> the second assignment.
Hi Herbert,
I also noticed this dupe a couple days ago and pointed it out to
the lkml and net code maintainers. Alexey Kuznetsov has
agreed, saying:
"Apparently, this is right. This happened ages ago when eliminating
second argument dev_queue_xmit()."
I assume a fix will be in the next major release.
Regards,
Bryan
-- Bryan Rittmeyer mailto:bryan@ixiacom.com- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/