Re: [Better Patch]: incorrect e2fsprog data from ver_linux script

[Albert Cranford]

Good find Steven.  Now I see the difference between
1.22 and 1.23.  This patch is better than the last patch.
Linus and Alan, please use this instead.
1.22 was "header then usage", while 
1.23 is "usage then header".

home1:# ./tune2fs 2>&1  |grep tune2fs
tune2fs 1.22, 22-Jun-2001 for EXT2 FS 0.5b, 95/08/09
Usage: ./tune2fs [-c max-mounts-count] [-e errors-behavior] [-g group]

home1:# /sbin/tune2fs 2>&1  |grep tune2fs
Usage: /sbin/tune2fs [-c max-mounts-count] [-e errors-behavior] [-g group]
tune2fs 1.23, 15-Aug-2001 for EXT2 FS 0.5b, 95/08/09

home1:# ./tune2fs 2>&1 | grep "^tune2fs" | sed 's/,//' |  awk 'NR==1 {print "e2fsprogs             ", $2}'
e2fsprogs              1.22
home1:# /sbin/tune2fs 2>&1 | grep "^tune2fs" | sed 's/,//' |  awk 'NR==1 {print "e2fsprogs             ", $2}'
e2fsprogs              1.23
--------PATCH--------------
--- linux/scripts/ver_linux.orig      Fri Aug 31 01:15:22 2001
+++ linux/scripts/ver_linux   Fri Aug 31 01:17:47 2001
@@ -26,7 +26,7 @@

 insmod -V  2>&1 | awk 'NR==1 {print "modutils              ",$NF}'

-tune2fs 2>&1 | grep tune2fs | sed 's/,//' |  awk \
+tune2fs 2>&1 | grep "^tune2fs" | sed 's/,//' |  awk \
 'NR==1 {print "e2fsprogs             ", $2}'

 reiserfsck 2>&1 | grep reiserfsprogs | awk \
----------END PATCH-------

Steven Cole wrote:
>
> So, this patch breaks the ver_linux script for 1.22, and 1.21 (I checked
> this too).  If someone wants to fix this right, please jump in.
> 
> Steven
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [e-mail]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Albert Cranford Deerfield Beach FL USA
[e-mail]