missing break? linux/drivers/video/riva/fbdev.c

andrew may (acmay@acmay.homeip.net)
Thu, 13 Sep 2001 21:26:17 -0700


I have noticed this in the 2.4.10-pre patches.

It looks like an obvious missing break on after rc =15;

diff -u --recursive --new-file v2.4.9/linux/drivers/video/riva/fbdev.c linux/drivers/video/riva/fbdev.c
--- v2.4.9/linux/drivers/video/riva/fbdev.c Wed Jul 25 17:10:24 2001
+++ linux/drivers/video/riva/fbdev.c Fri Sep 7 09:28:38 2001
@@ -260,7 +260,7 @@
#endif

#ifndef MODULE
-static const char *mode_option __initdata = NULL;
+static char *mode_option __initdata = NULL;
#else
static char *font = NULL;
#endif
@@ -1109,6 +1109,8 @@
break;
#endif
#ifdef FBCON_HAS_CFB16
+ case 15:
+ rc = 15; /* fix for 15 bpp depths on Riva 128 based cards */
case 16:
rc = 16; /* directcolor... 16 entries SW palette */
break; /* Mystique: truecolor, 16 entries SW palette, HW palette hardwired into 1:1 mapping */
@@ -1119,7 +1121,6 @@

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/