Re: Linux 2.4.10-pre11

Alexander Viro (viro@math.psu.edu)
Tue, 18 Sep 2001 05:31:48 -0400 (EDT)


On Mon, 17 Sep 2001, Linus Torvalds wrote:

> This also merges the blkdev in page cache patch, and that will hopefully
> make it noticeably easier to do the "do bread() with page cache too", at
> which point a lot of the current ugly synchronization issues will go away.

Umm... Linus, had you actually read through the fs/block_device.c part
of that? It's not just ugly as hell, it's (AFAICS) not hard to oops
if you have several inodes sharing major:minor. ->bd_inode and its
treatment are bogus. Please, read it through and consider reverting -
in its current state code is an ugly mess.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/