Re: Linux 2.4.10-pre11 -- __builtin_expect

Andreas Schwab (schwab@suse.de)
18 Sep 2001 13:13:48 +0200


Andi Kleen <ak@suse.de> writes:

|> +#define likely(x) __builtin_expect((x), !0)

IMHO, this should better be written as

#define likely(x) __builtin_expect(!!(x), 1)

because x is not required to be pure boolean, so any nonzero value of x is
as likely as 1.

Andreas.

-- 
Andreas Schwab                                  "And now for something
Andreas.Schwab@suse.de				completely different."
SuSE Labs, SuSE GmbH, Schanzäckerstr. 10, D-90443 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/