Re: Linux 2.4.10-pre11 -- __builtin_expect

Horst von Brand (vonbrand@sleipnir.valparaiso.cl)
Tue, 18 Sep 2001 16:11:06 -0400

Andreas Schwab <schwab@suse.de> said:
> Andi Kleen <ak@suse.de> writes:
> |> +#define likely(x) __builtin_expect((x), !0)
>
> IMHO, this should better be written as
>
> #define likely(x) __builtin_expect(!!(x), 1)
>
> because x is not required to be pure boolean, so any nonzero value of x is
> as likely as 1.

I don't think you are really thinking "likely", you are thinking "must_be"

-- 
Horst von Brand                             vonbrand@sleipnir.valparaiso.cl
Casilla 9G, Vin~a del Mar, Chile                               +56 32 672616
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/