Re: Magic SysRq +# in 2.4.9-ac/2.4.10-pre12

Randy.Dunlap (rddunlap@osdlab.org)
Wed, 19 Sep 2001 09:30:58 -0700


"Randy.Dunlap" wrote:
>
> 1. Was this stuff tested? How ???
>
> It always sets console_loglevel and then restores
> console_loglevel from orig_log_level, so Alt+SysRq+#
> handling is severely broken.
>
> If someone (Crutcher ?) wants to patch it, that's fine.
> If I patched it, I would just add a
> next_loglevel = -1;
> at the beginning of __handle_sysrq_nolock() and then
> let the loglevel handler(s) set next_loglevel.
> If next_loglevel != -1 at the end of __handle_sysrq_nolock(),
> set console_loglevel to next_loglevel.

I'll post a patch for these after I test it (soon).

~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/