Locking comment on shrink_caches()

Marcelo Tosatti (marcelo@conectiva.com.br)
Tue, 25 Sep 2001 14:49:40 -0300 (BRT)


Do you really need to do this ?

if (unlikely(!spin_trylock(&pagecache_lock))) {
/* we hold the page lock so the page cannot go away from under us */


Have you actually seen bad hold times of pagecache_lock by
shrink_caches() ?

Its just that I prefer clear locking without those "tricks". (easier to
understand and harder to miss subtle details)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/