PROBLEM: bug in fs/nfsd/vfs.c

Paul Raines (raines@nmr.mgh.harvard.edu)
Wed, 26 Sep 2001 18:18:34 -0400 (EDT)


I tracked down a bug with NFS mishandling group permissions to
the following typo in linux/fs/nfsd/vfs.c where ctime was used
where atime was supposed to be used. This is still present in
the 2.4.9 release.

*** linux/fs/nfsd/vfs.c.orig Thu Aug 30 12:55:19 2001
--- linux/fs/nfsd/vfs.c Thu Aug 30 12:55:27 2001
***************
*** 227,233 ****
#define MAX_TOUCH_TIME_ERROR (30*60)
if (err
&& (iap->ia_valid & BOTH_TIME_SET) == BOTH_TIME_SET
! && iap->ia_mtime == iap->ia_ctime
) {
/* looks good. now just make sure time is in the right ballpark.
* solaris, at least, doesn't seem to care what the time request is
--- 227,233 ----
#define MAX_TOUCH_TIME_ERROR (30*60)
if (err
&& (iap->ia_valid & BOTH_TIME_SET) == BOTH_TIME_SET
! && iap->ia_mtime == iap->ia_atime
) {
/* looks good. now just make sure time is in the right ballpark.
* solaris, at least, doesn't seem to care what the time request is

-- 
--------------------------------------------------------------
Paul Raines                  email: raines@nmr.mgh.harvard.edu
MGH-NMR Center.              tel:(617)-724-2369
149 (2301) 13th Street       fax:(617)-726-7422
Charlestown, MA 02129	USA

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/