Bug in tcp_v4_hnd_req?

[Ulrich Weigand]

Hello,

the following code in tcp_v4_hnd_req looks broken:

     if (nsk) {
          if (nsk->state != TCP_TIME_WAIT) {
               bh_lock_sock(nsk);
               return nsk;
          }
          tcp_tw_put((struct tcp_tw_bucket*)sk);
          return NULL;
     }

Shouldn't it put *nsk* instead of sk?  This appears to be the cause of
weird crashes under heavy network load we've been experiencing ...

Mit freundlichen Gruessen / Best Regards

Ulrich Weigand

--
  Dr. Ulrich Weigand
  Linux for S/390 Design & Development
  IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032 Boeblingen
  Phone: [phone]   ---   Email: [e-mail]