[patch] Fix 'get mouse type' command emulation in mousedev.c

Vojtech Pavlik (vojtech@suse.cz)
Thu, 27 Sep 2001 23:56:55 +0200


Hi!

New GPM (1.19.4+) uses a more sophisticated method of detecting PS/2
mice. This uncovers a minor bug in mousedev. Mousedev reports always
mouse type 4 (ExplorerPS/2) regardless of the mode it is in due to
missing break;'s in a switch statement. This patch fixes it. Patch against
2.4.10 or similar.

--- linux-2.4.10/drivers/input/mousedev.c Thu Sep 13 00:34:06 2001
+++ linux/drivers/input/mousedev.c Thu Sep 27 23:47:59 2001
@@ -314,9 +314,9 @@

case 0xf2: /* Get ID */
switch (list->mode) {
- case 0: list->ps2[1] = 0;
- case 1: list->ps2[1] = 3;
- case 2: list->ps2[1] = 4;
+ case 0: list->ps2[1] = 0; break;
+ case 1: list->ps2[1] = 3; break;
+ case 2: list->ps2[1] = 4; break;
}
list->bufsiz = 2;
break;

-- 
Vojtech Pavlik
SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/