Re: Re: BUG: cat /proc/partitions endless loop

[Joachim Weller]

Christoph Hellwig <[e-mail]> schrieb am 28.09.01:
> In article <[e-mail]> you wrote:
> >  I traced the problem down to drivers/block/genhd.c, 
> > where the function get_partition_list() outer loop does not 
> > terminate due to the last element in the structured list starting 
> > with gendisk_head is not initialized to NULL, by whatever reason.
> > My fix does not cure the pointered endless loop, but prevents
> > from looping when stepping thru the pointered list.
> 
> I think the fix could be simpler.  What about:
[...] 

> + for (gp = gendisk_head; gp != gendisk_head; gp = gp->next) {

This will break your for loop immedeately, because the loop criteria
is already violated by the initialization !

But I tried another solution:
  for (gp = gendisk_head; gp && (gp->next != gendisk_head); gp = gp->next) {

with no success - the cat /proc/partition only printed the heading line.
This proofed to me, that the pointered list is created the wrong way,
in other words, gendisk_head->next is a pointer to itself.
It looks to me, that the "next" field in 
/*static*/ struct gendisk *gendisk_head;
is not initialized (by the compiler ?) correctly to NULL. 

>     if (gp->part[n].nr_sects == 0)
>      continue;
> 
>  

_______________________________________________________________________
1.000.000 DM gewinnen - kostenlos tippen - http://millionenklick.web.de
[e-mail], 8MB Speicher, Verschluesselung - http://freemail.web.de