Re: PnP BIOS + 2.4.9-ac16 = no boot

Stelian Pop (stelian.pop@fr.alcove.com)
Fri, 28 Sep 2001 16:54:06 +0200


On Fri, Sep 28, 2001 at 10:41:45AM -0400, Thomas Hood wrote:

> Stelian Pop wrote:
> > What about making a conditional on 'is_sony_vaio_laptop' here ?
> > (but you need to extends the conditionnal export of this variable
> > from dmi_scan.c / i386_ksyms.c).
>
> In addition to applying the patch I just sent
> (thood-pnpbiosvaio-patch-20010928-3), you will have
> to move the definition of is_sony_vaio_laptop outside
> the #ifdefs in arch/i386/kernel/dmi_scan.c and i386_ksyms.c

No need for me since I have CONFIG_SONYPI on.

> You or Alan: For the cleaned up patch, do we export this
> variable unconditionally?

I'd vote for unconditionnally define one int instead of having
something like:
#if defined(CONFIG_SONYPI) || defined(CONFIG_SONYPI_MODULE) || ( defined(CONFIG_PNP) && defined(CONFIG_PROC) )
(and maybe other defines in the future... :( ).

Stelian.

-- 
Stelian Pop <stelian.pop@fr.alcove.com>
|---------------- Free Software Engineer -----------------|
| Alc˘ve - http://www.alcove.com - Tel: +33 1 49 22 68 00 |
|------------- Alc˘ve, liberating software ---------------|
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/