[PATCH] Re: 4GB MemShared, Cached bigger (and growing) than MemTotal

[Hugh Dickins]

On 1 Oct 2001, Christoph Rohland wrote:
> On Sun, 30 Sep 2001, Mike Fedyk wrote:
> > 
> > After this happened, I saw MemShared go up to about 4GB, and Cached
> > started growing, getting even bigger than ram!
> 
> Apparently the shmem accounting is screwed. (Hugh does something ring
> at your side?) 

I've now looked, and it's obviously my error in -ac shmem_writepage:
patch below against 2.4.10-ac2, would apply equally to 2.4.9-ac16 on.

Hugh

--- 2.4.10-ac2/mm/shmem.c	Mon Oct  1 21:36:28 2001
+++ linux/mm/shmem.c	Mon Oct  1 21:41:00 2001
@@ -462,6 +462,7 @@
 		swap_list_unlock();
 		/* Add it back to the page cache */
 		add_to_page_cache_locked(page, mapping, index);
+		atomic_inc(&shmem_nrpages);
 		activate_page(page);
 		SetPageDirty(page);
 		error = -ENOMEM;