Re: [RFC] register_blkdev and unregister_blkdev

[BALBIR SINGH]

This is a multi-part message in MIME format.

--------------InterScan_NT_MIME_Boundary
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Alexander Viro wrote:

>>I was looking at the code for register_blkdev and unregister_blkdev. I 
>>found that no
>>locking (spinlocks) are used to protect the blkdevs struture in these 
>>functions. I suspect
>>we have not seen a problem till now since
>>
>
>... they are only called under BKL; ditto for lookups in the tables they
>(de-)populate.
>
What I wanted to know was, who is calling/holding the BKL? Is it because
lock_kernel is called in sys_create_module() and sys_init_module().

I also looked at sd.c, it does not hold the BKL before calling register_blkdev()
it calls devfs_register_blkdev() from sd_init().

Maybe I am still missing something.

Balbir

--------------InterScan_NT_MIME_Boundary
Content-Type: text/plain;
	name="Wipro_Disclaimer.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="Wipro_Disclaimer.txt"

----------------------------------------------------------------------------------------------------------------------
Information transmitted by this E-MAIL is proprietary to Wipro and/or its Customers and
is intended for use only by the individual or entity to which it is
addressed, and may contain information that is privileged, confidential or
exempt from disclosure under applicable law. If you are not the intended
recipient or it appears that this mail has been forwarded to you without
proper authority, you are notified that any use or dissemination of this
information in any manner is strictly prohibited. In such cases, please
notify us immediately at mailto:[e-mail] and delete this mail
from your records.
----------------------------------------------------------------------------------------------------------------------

--------------InterScan_NT_MIME_Boundary--