Re: [PATCH] various minor cleanups against 2.4.13-pre3 - comments requested

Christoph Hellwig (hch@ns.caldera.de)
Tue, 16 Oct 2001 21:59:08 +0200

In article <3BCC8C88.58BBCC39@eisenstein.dk> you wrote:
> kernel/exec_domain.c :
> Contrary to most other files in the kernel source the functions
> in exec_domain.c are defined with the
> return values on a line by themselves. Most places in kernel
> source have the entire function definition
> on a single line (as long as it does not exceed 80 chars in
> length). So I moved the function definitions
> onto a single line.

NO. This file is maintained and that style is intentional.
(BTW, you could compare it to output of scripts/Lindent..)

> kernel/exec_domain.c : get_exec_domain_list()
> The len variable (signed) is compared to PAGE_SIZE (unsigned).
> Changing len to "unsigned int" avoids
> comparison between signed and unsigned.

Looks sane to me.

Christoph

-- 
Of course it doesn't work. We've performed a software upgrade.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/