Re: [PATCH] Oops in usb-storage.c

Jan Niehusmann (jan@gondor.com)
Wed, 17 Oct 2001 23:03:13 +0200


On Wed, Oct 17, 2001 at 12:15:40PM -0700, Matthew Dharm wrote:
> This looks better... but you have a dangerous memset() in an else clause --
> the request buffer pointer could be pointing to a scatter-gather list, so
> you can't just memset on it.

Oh yes, I see - this memset is probably useless with the latest patch.
With an older version, it prevented the return of garbage from INQUIRY
in some cases, but with the later version INQUIRY is handeld specially
anyways.

Jan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/