Re: [PATCH] linux-2.4.13 - i8xx series chipsets patches

[Wim Van Sebroeck]

Hi Alan,

> >  static struct pci_device_id i810tco_pci_tbl[] __initdata = {
> > -	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801AA_0,	PCI_ANY_ID, PCI_ANY_ID, },
> > -	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801AB_0,	PCI_ANY_ID, PCI_ANY_ID, },
> > -	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_0,	PCI_ANY_ID, PCI_ANY_ID, },
> > -	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_10,	PCI_ANY_ID, PCI_ANY_ID, },
> > +	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801AA_0, PCI_ANY_ID, PCI_ANY_ID, },
> > +	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801AB_0, PCI_ANY_ID, PCI_ANY_ID, },
> > +	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_0, PCI_ANY_ID, PCI_ANY_ID, },
> 
> Why all this renaming and reformatting - what does your patch really do
> other than generate a lot of pointless noise

Sorry to upset you for this reformatting. What I did was look at the I/O Controller Hub of the intel 8xx series of chipsets and had a look what was supported and what was not. The 82801CA and 82801CAM I/O Controller Hubs were not supported yet and thus I added support for this in the IDE code, the watchdog timer and the random number generator. These Hubs will support intel 830 and intel 830MP (and probably others in the future as well) series of motherboards. 
My main source of info was the datasheets from intel on the different 82801 chips.

> 
> > -	1a21  82840 840 (Carmel) Chipset Host Bridge (Hub A)
> > +	1a21  82840 840 [Carmel] Chipset Host Bridge (Hub A)
> 
> And why break all the bracketing so that it isnt like other table
> entries ?

I checked why I changed to the square brackets: they are normally used when you need to strip if the
description is too long. In this case it indeeds make no sense. Sorry about this.

Greetings,
Wim.