Re: [PATCH] 8139too thread termination

Robert Kuebel (kuebelr@email.uc.edu)
Tue, 30 Oct 2001 19:30:10 -0500


i was so wrapped up in digging through kmalloc(), that i missed the
memset() in alloc_netdev(). duh!

On Tue, Oct 30, 2001 at 07:18:50PM -0500, Jeff Garzik wrote:
> Robert Kuebel wrote:
> >
> > ok, i am wondering if i have made a mistake. this patch will make the
> > kernel thread die when tp->time_to_die is true. tp is kmalloc()'ed
> > inside of alloc_etherdev. i didn't initialize time_to_die to 0, but
> > this patch has been working perfectly for me. am i just lucky or are
> > kmalloc()'ed regions zero'ed out?
>
> And here I thought you did it on purpose :)
>
> alloc_etherdev zeroes memory it allocates, so in net drivers all private
> structures can be considered initialized to zero when you get them.
>
> Jeff
>
>
> --
> Jeff Garzik | Only so many songs can be sung
> Building 1024 | with two lips, two lungs, and one tongue.
> MandrakeSoft | - nomeansno
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/