Re: SCSI tape crashes (was Re: BUG() in asm/pci.h:142 with 2.4.13)

Jens Axboe (axboe@suse.de)
Wed, 31 Oct 2001 09:33:53 +0100


On Tue, Oct 30 2001, Dan Maas wrote:
> > Can people try out this patch? I believe this will fix the bug.
> > + tb->sg[0].page = NULL;
> > if (tb->sg[segs].address == NULL) {
>
> For the sake of making this clear to other kernel hackers (I got bitten by
> it too) - starting with 2.4.13 you must zero out the fields of struct
> scatterlist that you are not using. i.e. it is no longer sufficient to
> simply set sg.address and sg.length, because junk might still be present in
> the new sg.page field, and pci_map_*() will BUG() if both sg.address and
> sg.page are non-zero.

True, perhaps we should add a init_sg or something like that.

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/