Re: [PATCH] TCP ECN bits and TCP_RESERVED_BITS macro

Neil Spring (nspring@saavie.org)
Wed, 31 Oct 2001 18:53:59 -0800


> Dans un message du 31 oct ? 15:43, Neil Spring ?crivait :
> > The line in your patch:
> > > -#define TCP_HP_BITS (~(TCP_RESERVED_BITS|TCP_FLAG_PSH)|TCP_FLAG_ECE|TCP_FLAG_CWR)
> > > +#define TCP_HP_BITS (~(TCP_RESERVED_BITS|TCP_FLAG_PSH))
> >
> > is, I believe, a very bad idea. This preprocessor constant
>
> Well it is not.

You're absolutely right. And it is more clean, even if
it confused me at first. Thanks for the explanation.

-neil
nethack told me to be careful, full moon tonight, but I
didn't listen.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/