small bug? in drivers/video/vgacon.c

Stepan Koltsov (yozh@island.mx1.ru)
Thu, 1 Nov 2001 12:38:59 +0300


Hi.

Function drivers/video/vgacon.c:vgacon_scrolldelta() doesn't work
when get 1 or -1 as 2nd arg (it doesn't scroll).
This bug can be seen rarely, cos usually this func never called with 1 or -1.
I don't quite understand, how this func works :-) but vgacon_scrolldelta
works properly with this small patch.

diff -ur linux-2.4.12-orig/drivers/video/vgacon.c linux-2.4.12/drivers/video/vgacon.c
--- linux-2.4.12-orig/drivers/video/vgacon.c Fri Sep 14 03:04:43 2001
+++ linux-2.4.12/drivers/video/vgacon.c Sat Oct 20 19:29:20 2001
@@ -931,7 +931,7 @@
c->vc_visible_origin = c->vc_origin;
else {
int vram_size = vga_vram_end - vga_vram_base;
- int margin = c->vc_size_row * 4;
+ int margin = c->vc_size_row;
int ul, we, p, st;

if (vga_rolled_over > (c->vc_scr_end - vga_vram_base) + margin) {

-- 
mailto:yozh@mx1.ru
ICQ:26521795

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/