Re: [PATCH] cache colour task_structs

Manfred Spraul (manfred@colorfullife.com)
Thu, 01 Nov 2001 11:49:23 +0100

Alan Cox wrote:
>
> > The attached patch moves the task structure into a slab, with normal
> > cache colouring.
> > It's tested with i386 SMP.(i.e. it boots and runs X)
>
> Keeping the stack and task struct together is smarter. You fix the one
> problem but not the other horror.
>
If we keep both together we are limited to 8 kB for stack, task
structure and slack for colouring - I'm not sure if that won't cause
stack overruns. We are already down to 6.3 kB stack.

> We need to perturb esp colour too. It might be the right way to do this
> is slab based kernel stacks, it might be that your code is cheaper than
> the cost of getting current the really hard way and we should just add
> random numbers to the initial esp of a task ?
>
Adding a random amount would be a one line change to copy_thread.

--
	Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/