Re: [PATCH] net/ipv4/*, net/core/neighbour.c jiffies cleanup

Andreas Dilger (adilger@turbolabs.com)
Thu, 8 Nov 2001 11:10:24 -0700


On Nov 08, 2001 20:54 +0300, kuznet@ms2.inr.ac.ru wrote:
> I want to _ask_ one thing people working on these changes.
> _Please_, defer this edit to 2.5. The changes are very good,
> but time for them is very bad.
>
> When I wrote this code the macros did not exist.

Well, Alan said the same thing, and I went and checked - the macros existed
since 2.1.106, probably the last time there was a "jiffies wrap" effort. It
is more likely that nobody knows about them, because nobody uses them,
because nobody knows about them, etc.

> However, this code is right, take my word. Hence, it is pure maintanance
> problem and as soon as main reader of this code is me, I would be glad to
> see the changes, but only having no deadlines.

If people don't want to see them, that is fine with me - they will stop.

Tim and I were only trying to fix instability that he noticed when
initializing jiffies to some large pre-wrap value. If people are OK
with 2.4 Linux boxes hanging after 497 days, that is fine with me.

The only box I have that could stay up that long is my router (486/33),
and it does not have a UPS so it is not likely to actually make it
(record is 6 months or so).

Cheers, Andreas

--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/