Re: [PATCH] hgafb oopses

[Geert Uytterhoeven]

On Mon, 12 Nov 2001, Bakonyi Ferenc wrote:
> On Mon, 12 Nov 2001, Geert Uytterhoeven wrote:
> > Sorry... Anyway, the old code was broken too, since it wasn't portable.
>
> Is it portable now? Can you test it on non-i386?

Unfortunately not. I don't have HGA hardware.

All I can do is read the code and comment :-)

> > > The patch below is against 2.4.15-pre1. It resolves the ISA address
> > > confusion, replaces scr_{read|write} functions with isa_{read|write},
> > > and elimiates a cosmetic compiler warning about suggested parens.
>
> > But it does some other Bad Things(TM): putting ISA memory _adresses_ and
> > _16_bit_ values in _unsigned_chars_ is not good for your health...
>
> There is no mercy for my brain-damage, patch follows.
>
> --- linux-2.4.15-pre3/drivers/video/hgafb.c	Mon Nov 12 13:16:32 2001
> +++ linux/drivers/video/hgafb.c	Mon Nov 12 13:15:56 2001
> @@ -312,8 +312,8 @@
>  static int __init hga_card_detect(void)
>  {
>  	int count=0;
> -	unsigned char p, p_save;
> -	unsigned char q, q_save;
> +	unsigned long p, q;
> +	unsigned short p_save, q_save;
>
>  	hga_vram_base = 0xb0000;
>  	hga_vram_len  = 0x08000;

Thanks, that looks better!

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds