Re: Fw: [Patch] Some updates to serial-5.05

[Stuart MacDonald]

From: "Jeff Garzik" <[e-mail]>
> Easily.  Your patch:
> > +  case TIOCSER485GET:
> > +  case TIOCSER485SET:
> > +   if (state->lmode_fn)
> > +    return (state->lmode_fn)(state, cmd,
> > +       (unsigned int *) arg);
> > +   else
> > +    return -EINVAL;
> >    case TIOCMGET:
> >     return get_modem_info(info, (unsigned int *) arg);
> >    case TIOCMBIS:
>
> 2.4.x serial.c:
> >                 case TIOCMGET:
> >                         return get_modem_info(info, (unsigned int *)
arg);
> >                 case TIOCMBIS:
>
> The formatting is blatantly, obviously different.

Something is broken along the way then, as I have:
..?
Grrr. Something wicked (windowsian) has damaged all
the tabs when I was inlining the patches.

Hm. Attaching the patches mangles (uuencodes) them and
inlining them damages the tabs. So. Please get the patch tarball
from: ftp://ftp.connecttech.com/pub/linux/blueheat/

> Doubtful.  When applied to 2.4.x-current:
>
> [jgarzik@rum linux_2_4]$ patch drivers/char/serial.c < ~/tmp/patch
> patching file drivers/char/serial.c
> Hunk #1 FAILED at 1405.
> Hunk #2 FAILED at 2514.
> Hunk #3 FAILED at 2572.
> Hunk #4 FAILED at 3968.
> patch: **** malformed patch at line 55: {

You're right, the patches tend not to apply to non-5.05 versions.
However, applying them to 2.4.14 doesn't give me the above. What
exactly is 2.4.x-current, and where can I get it?

I'll do a patch set against 5.05c, should rmk or tytso request it.
Unless you're also a serial maintainer of some description?

..Stu