Re: 2.4.14 compiling failed

[Adrian Bunk]

On Sat, 17 Nov 2001, Peter Jay Salzman wrote:

> this is probably known already, but just in case, 2.4.14 compiling just
> failed on me:
>...
>   drivers/block/block.o: In function `lo_send':
>   drivers/block/block.o(.text+0xa57f): undefined reference to `deactivate_page'
>   drivers/block/block.o(.text+0xa5c9): undefined reference to `deactivate_page'
>   make: *** [vmlinux] Error 1
>...
> so i went to update to 2.4.14.  and the compile just failed.
>
> no big deal -- i can live with it until 2.4.15 comes out, but i thought
> someone should know about this.
>
> no response is required.  i know how busy everyone here is.

I hope you don't mind that I respond.  ;-)

This is a known bug.
If you want to run 2.4.14 the following simple patch solves the problem:

--- linux-2.4.14-broken/drivers/block/loop.c	Thu Oct 25 13:58:34 2001
+++ linux-2.4.14/drivers/block/loop.c	Mon Nov  5 17:06:08 2001
@@ -207,7 +207,6 @@
 		index++;
 		pos += size;
 		UnlockPage(page);
-		deactivate_page(page);
 		page_cache_release(page);
 	}
 	return 0;
@@ -218,7 +217,6 @@
 	kunmap(page);
 unlock:
 	UnlockPage(page);
-	deactivate_page(page);
 	page_cache_release(page);
 fail:
 	return -1;

> pete  (not subscribed)

cu
Adrian

-- 

Get my GPG key: finger [e-mail] | gpg --import

Fingerprint: B29C E71E FE19 6755 5C8A  84D4 99FC EA98 4F12 B400