Re: [2.4.15pre6] Funny error on "make modules_install" - cosmetic cleanup probably needed

[Keith Owens]

On Mon, 19 Nov 2001 02:32:58 -0600, 
Mark Orr <[e-mail]> wrote:
>make[2]: Entering directory `/usr/src/linux/drivers/cdrom'
>mkdir -p /lib/modules/2.4.15-pre6/kernel/drivers/cdrom/
>cp cdrom.o cdrom.o /lib/modules/2.4.15-pre6/kernel/drivers/cdrom/
>cp: will not overwrite just-created `/lib/modules/2.4.15-pre6/kernel/drivers/cdrom/cdrom.o' with `cdrom.o'

There are several places where a module gets installed twice, because
of the way that module objects are selected in 2.4 (2.5 does not have
this feature).  The fix is easy but it should not be necessary.  IMNSHO
it is *wrong* for fileutils to decide that it will not copy a file
twice, cp should do what the user asked.  Complain to the fileutils
maintainer as a first step.

Work around for unexpected cp behaviour, against 2.4.14, untested.

Index: 14.1/Rules.make
--- 14.1/Rules.make Wed, 07 Mar 2001 23:04:43 +1100 kaos (linux-2.4/T/c/47_Rules.make 1.1.2.2 644)
+++ 14.1(w)/Rules.make Mon, 19 Nov 2001 23:42:58 +1100 kaos (linux-2.4/T/c/47_Rules.make 1.1.2.2 644)
@@ -173,7 +173,7 @@ modules: $(ALL_MOBJS) dummy \
 _modinst__: dummy
 ifneq "$(strip $(ALL_MOBJS))" ""
 	mkdir -p $(MODLIB)/kernel/$(MOD_DESTDIR)
-	cp $(ALL_MOBJS) $(MODLIB)/kernel/$(MOD_DESTDIR)$(MOD_TARGET)
+	cp $(sort $(ALL_MOBJS)) $(MODLIB)/kernel/$(MOD_DESTDIR)$(MOD_TARGET)
 endif
 
 .PHONY: modules_install