Re: if (a & X || b & ~Y) in dasd.c

[bill davidsen]

In article <[e-mail]> [e-mail] wrote:
>Carsten and others:
>
>this code in 2.2.14 looks suspicious to me:
>
>./drivers/s390/block/dasd.c:
>        /* first of all lets try to find out the appropriate era_action */
>        if (stat->flag & DEVSTAT_FLAG_SENSE_AVAIL ||
>            stat->dstat & ~(DEV_STAT_CHN_END | DEV_STAT_DEV_END)) {

  If the code does what I think it does, it works as written. However, I
usually would throw in parenthesis on something like this to be sure
that the next person reading the code won't waste time thinking about
it. I always thought that good code was literature, which could be read,
understood, and enjoyed by many.

-- 
bill davidsen <[e-mail]>
  His first management concern is not solving the problem, but covering
his ass. If he lived in the middle ages he'd wear his codpiece backward.