> No. sock_writable() is for datagram sockets, TCP never used or
> satisfied this predicate, it used(s) more interesting one.
> BTW applications need not use this anyway, we do not awake
> people for no reasons. If a write failed with EAGAIN, wakeup
> will happen only when there is some room for write. And it will
> not be awaken again until the next write will fail. So, if you
> rejected wakeup (due to wrong predicate), nobody will remind
> you again.
Thanks... Then the patch I sent Birger is very likely the correct one.
Originally I had a test for whether sock_wspace(sk) was greater than
some minimal value. We need this for UDP in order to avoid waking up
'rpciod' before the socket buffer is large enough to accommodate the
RPC datagram. As the same code worked in 2.2.x for TCP, I had assumed
it was OK...
Cheers,
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/